Undef default for $notify_update in source.pp results in problem with Puppet 3.7.2

[cpavanrun]

Puppet master 3.7.2 (the default repo version for Debian) gives the following error:

Error: "" is not a boolean. It looks to be a String on node X

I have deduced the problem to the default undef value for $notify_update in apt::source.pp. This pp relays the undef to apt::settings at line 120 resulting in the default $notify_update's value of true being set to something weird resulting in the error mentioned above.

I can easily circumvent this by passing on an actual value of $notify_update to apt::source but just wanted to let you know... =D

[daenney]

Thanks @cpavanrun, that's good to know.

@bmjen @hunner What are your thoughts? I'm not sure I'm up for merging this change, mostly b/c I believe the only still supported Puppet 3 range is 3.8, by virtue of PE still shipping with it and generally future parser in 3.7 prior to 3.7.3 not behaving entirely correctly.

[olasd]

Hi,

puppetlabs-apt is marked as supporting "Puppet >= 3.0.0 < 5.0.0". If that's not really the case it should be updated. I think it'd be a shame to explicitly not support the Puppet version that's packaged in the current stable Debian release :)

If this PR is not merged, then the docs should be updated, as they reference the default value for $notify_update as being true.

[DavidS]

There is a thin, blurry line between supported as in "these versions should work together", and supported as in "Puppet will take your money to fix issues for you."

In this case, the fix seems innocuous enough, and passes tests. So in it goes!

[olasd]

Thanks a bunch, @DavidS !