Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This started by me attempting to fix setting
choco_install_location
to a path containing a space, ex:C:/Program Data/chocolatey
Ultimately this resulted in reworking
install.pp
to use the new install script. The documented script can be found here: https://community.chocolatey.org/install.ps1The new install script primarily uses environment variables to customize behavior, but required slight modification in order to customize the 7zip download url. Thus the [SIG] block provided by chocolatey was removed.
The biggest change in behavior for this module is no longer managing the installation of 7zip. The new script uses built-in powershell cmdlets to extract the nupkg assuming powershell 5+, which in all fairness should be the majority of users. If powershell < 5 detected, the install script is still able to download and install 7zip if needed.
Related Issues (if any)
Checklist
puppet apply
)