Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New install script #363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

garrettrowell
Copy link

Summary

This started by me attempting to fix setting choco_install_location to a path containing a space, ex: C:/Program Data/chocolatey

Ultimately this resulted in reworking install.pp to use the new install script. The documented script can be found here: https://community.chocolatey.org/install.ps1

The new install script primarily uses environment variables to customize behavior, but required slight modification in order to customize the 7zip download url. Thus the [SIG] block provided by chocolatey was removed.

The biggest change in behavior for this module is no longer managing the installation of 7zip. The new script uses built-in powershell cmdlets to extract the nupkg assuming powershell 5+, which in all fairness should be the majority of users. If powershell < 5 detected, the install script is still able to download and install 7zip if needed.

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@garrettrowell garrettrowell requested a review from a team as a code owner October 16, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant