Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated Beaker methods #69

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

mhashizume
Copy link
Contributor

This PR updates several deprecated Beaker methods that were removed entirely in Beaker 5. This is in preparation for moving to Beaker 5 for tests.

@mhashizume mhashizume added the maintenance Maintenance chores are typically excluded from changelogs label Feb 1, 2024
@mhashizume mhashizume requested a review from a team as a code owner February 1, 2024 16:46
This commit removes logic that skipped tests on older agents that are no
longer supported.
The assert_no_match method in Beaker was long deprecated then eventually
removed altogether in voxpupuli/beaker@6282311

This commit updates assert_no_match to refute_match.
Previously in Beaker, you could use standalone stdout and stderr methods
to access output from remote machines.

These methods were deprecated in 2013 with voxpupuli/beaker@28b2510 and
dropped entirely in voxpupuli/beaker@73a31c7.

This commit removes these methods from Beaker tests in favor of calling
stdout and stderr methods on Result objects.
@mhashizume mhashizume force-pushed the PA-5022/main/beaker-deprecated branch from 24e9a5e to 1cf6dd8 Compare February 1, 2024 20:08
@cthorn42 cthorn42 merged commit 429eecf into puppetlabs:main Feb 2, 2024
14 checks passed
@mhashizume mhashizume deleted the PA-5022/main/beaker-deprecated branch February 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants