docker::services: Fix using multiple published ports #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the class docker::services already allowed arrays to be
specified for
publish
ports, it didn't handle this correctly sincethis array was simply converted to a string and passed onto Docker,
like so:
To correctly publish multiple ports, the
--publish
parameter has tobe called specified for each port.
This patch also introduces a new spec test to check this behavior