MODULES-1309 - Make package and service names configurable

[underscorgan]

This was motivated by a need to make this work on Debian Jessie.

[hesco]

I suspect that line 31 of firewall::params will not do what we intend in my environment.

# facter -p operatingsystemrelease
jessie/sid 

also, do we need to account for both packages?

# dpkg -l | grep iptables
ii  iptables                       1.4.21-2+b1                   amd64        administration tools for packet filtering and NAT
ii  iptables-persistent            1.0.2                         all          boot-time loader for netfilter rules, iptables plugin

[hesco]

Thanks Morgan:

You wound up touching a few more files than I had imagined on first blush with this issue.
I reviewed the patch thoroughly, and other than the notes above, (and the fact that I have
run no tests) this looks like it ought to get the job done. I assume this is also slated for 1.3.0?
Looking forward to seeing it soon.

-- Hugh

[underscorgan]

@hesco versioncmp is magic and knows that jessie/sid >= 8.0 :)

and the iptables package is defined at https://github.com/puppetlabs/puppetlabs-firewall/blob/master/manifests/linux.pp#L22-L24, so we should be good for that. I think the general thought is that firewall::linux::debian will be included from firewall

[underscorgan]

@hesco oh, and yes, this should make it in for 1.3.0

[hunner]

https://docs.puppetlabs.com/guides/module_guides/bgtm.html#b-parameters would say that this should be package_name