Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multiple ipsets in a rule #615

Merged
merged 1 commit into from
May 16, 2016

Conversation

nabam
Copy link

@nabam nabam commented Mar 8, 2016

Support for multiple ipsets in a single rule. This feature is very handy
if you need to match source and destination from different ipsets.
Iptables arguments are a bit wierd, but it works, details are in
https://utcc.utoronto.ca/~cks/space/blog/linux/IptablesIpsetsMultipleMatches

@nabam nabam force-pushed the multiple-ipset branch 3 times, most recently from a204b8b to e6c5d6e Compare March 8, 2016 23:50
Support for multiple ipsets in a single rule. This feature is very handy
if you need to match source and destination from different ipsets.
Iptables arguments are a bit wierd, but it works, details are in
https://utcc.utoronto.ca/~cks/space/blog/linux/IptablesIpsetsMultipleMatches
@bmjen
Copy link
Contributor

bmjen commented Mar 18, 2016

This looks ok to me. Can @jonnytpuppet take a look at this to double check the formatting?

@tphoney
Copy link
Contributor

tphoney commented Apr 7, 2016

@jonnytpuppet ping

@daenney
Copy link

daenney commented Apr 18, 2016

Ping @hunner

@HelenCampbell
Copy link
Contributor

Hey @nabam , thank you for contributing! Sorry about the lack of review so far, I'm pushing to get this PR seen to in our next community meeting on Thursday. Thank you for your patience.

@jonnytdevops
Copy link
Contributor

@nabam Thank you so much for your contributions!

It would be appreciated if you could do a README update to state that multiple values can be passed in.

Also, I'd love to see an acceptance test using multiple values, just to prove that this continues to work on multiple platforms.

Thanks!

@nabam
Copy link
Author

nabam commented May 7, 2016

@jonnytpuppet isn't it already done?

@daenney
Copy link

daenney commented May 8, 2016

@jonnytpuppet Looking at the code all the concerns you've mentioned are already addressed in the original PR. There's a small patch to the README mentioning it can take a string or array and there's an acceptance test that has multiple values.

@jonnytdevops jonnytdevops merged commit d5aea97 into puppetlabs:master May 16, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-firewall that referenced this pull request Oct 23, 2017
support for multiple ipsets in a rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants