Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-1144) - Conversion of ERB to EPP templates #564

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

praj1001
Copy link

@praj1001 praj1001 commented Jul 20, 2023

Summary

Conversion of ERB to EPP templates for haproxy module.

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@praj1001 praj1001 requested a review from a team as a code owner July 20, 2023 10:05
@malikparvez
Copy link
Member

could you also clean up the commits...

@praj1001 praj1001 changed the title Conversion of ERB to EPP templates (CONT-1144) - Conversion of ERB to EPP templates Jul 25, 2023
@praj1001 praj1001 force-pushed the CONT-1144-erb_to_epp_conversion_haproxy branch from 9197e04 to 5678de5 Compare July 25, 2023 10:34
@praj1001 praj1001 force-pushed the CONT-1144-erb_to_epp_conversion_haproxy branch from 5678de5 to a32adb5 Compare July 25, 2023 10:35
@jordanbreen28 jordanbreen28 merged commit f753694 into main Jul 25, 2023
33 checks passed
@jordanbreen28 jordanbreen28 deleted the CONT-1144-erb_to_epp_conversion_haproxy branch July 25, 2023 11:11
@a-courteille
Copy link

Hi there,
Since the PR is merged, the option template seems to be malfunctioning.
By applying puppet, the following changes are applied on the maxconn option :

-  maxconn 150
+  maxconn 0
+  maxconn 1
+  maxconn 2
+  maxconn 3 
+  maxconn 4
+  maxconn 5
+  maxconn 6
...

Until maxconn 149
I'm using this call :

options => {
  'maxconn'       => 150,
}

by trying to set the value to String type

options => {
  'maxconn'       => '150',
}

The problem seems to be resolved.

I tested the commit before this PR and nothing to report. I think the change of template engine induced this anomaly.
Or maybe it's a normal breaking change ?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants