Add merge_options for haproxy::defaults
#588
Merged
+124
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakatz
force-pushed
the
feature/defaults_mergeconfig
branch
from
a7cb59a
to
2e6bc46
Compare
Ramesh7
previously approved these changes
Oct 19, 2023
|
Changes looks good to me but I am not expert on this module. If we can get another review from community, we should be good to go after that. |
bastelfreak
previously approved these changes
Oct 24, 2023
bastelfreak
reviewed
Oct 24, 2023
yakatz
force-pushed
the
feature/defaults_mergeconfig
branch
from
2e6bc46
to
1d87daf
Compare
bastelfreak
approved these changes
Nov 21, 2023
Ramesh7
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are default options which would be nice to have in all defaults sections. Add an option to include them.
Checklist
puppet apply)