Allow ports parameters as Stdlib::Ports #610
Merged
+173
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the ports parameters must be specified as one of: * `'1234'` * `'1234,5678'` * `['1234']` * `['1234','5678']` Allow it to also be specified as the `Stdlib::Port` type. e.g. * `1234` * `[1234]` * `[1234,5678]` To encourage this direction the documentation has been updated to use `Stdlib::Port` types. The old formats are still supported. Motivation here is we were happily using v4 of this module with integer specifications for ports and this is better anyway. Some future version could drop the old stringified ports.
bastelfreak
approved these changes
May 22, 2024
Yep that should be the case and was my intention. Its a good candidate for a breaking change down the line but no urgency from me on that. |
|
@traylenator could you do me a favour and also provide a PR as breaking change that drops the other types? <3 Just so that we don't forget it for the next major release? |
traylenator
added a commit
to traylenator/puppetlabs-haproxy
that referenced
this pull request
May 22, 2024
Previously it was possible to set the ports parameter as: * `'1234'` * `'1234,5678'` * `['1234']` * `['1234','5678']` Since puppetlabs#610 the ports parameter could also be specified with `Stdlib::Ports`: * `1234` * `[1234]` * `[1234, 5678]` With this patch all the previous string values are deprecated and will fail. The `Stdlib::Port` values must be used.
3 tasks
traylenator
added a commit
to traylenator/puppetlabs-haproxy
that referenced
this pull request
May 22, 2024
Previously it was possible to set the ports parameter as: * `'1234'` * `'1234,5678'` * `['1234']` * `['1234','5678']` Since puppetlabs#610 the ports parameter could also be specified with `Stdlib::Ports`: * `1234` * `[1234]` * `[1234, 5678]` With this patch all the previous string values are deprecated and will fail. The `Stdlib::Port` values must be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the ports parameters must be specified as one of:
'1234''1234,5678'['1234']['1234','5678']Allow it to also be specified as the
Stdlib::Porttype. e.g.1234[1234][1234,5678]To encourage this direction the documentation has been updated to use
Stdlib::Porttypes.The old formats are still supported.
Motivation here is we were happily using v4 of this module with integer specifications for ports and this is better anyway.
Some future version could drop the old stringified ports.
Checklist
puppet apply)