Support for installing JCE. Fixes MODULES-1681 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to get the default Java version rollout with Ubuntu 18.04.
…ration options match the current java download URL provided by Oracle.
(MODULES-8025) Switch default for Ubuntu 18.04 to 11
Optimized code for making java::oracle atomic. Fixes MODULES-8085
|
@dploeger Apologies but after enabling your test's and running them through an adhoc pipeline they failed against both Redhat 6 and 7. |
Fix OpenJDK paths on Debian based OS with ARM
|
@david22swan No problem. How can I test Redhat 6 and 7. I tried running the acceptance tests on centos 7 and everything went smooth. |
…ration options match the current java download URL provided by Oracle.
# Conflicts: # manifests/oracle.pp # spec/defines/oracle_spec.rb
|
Rebased |
|
@dploeger Within the team we generate our own custom nodesets. Since you don't have access to this feature, here are some nodesets for both: Just create some new .yml files in the nodeset folder and copy this into them. After that it's no different from running the test's in centos. |
|
@david22swan Hm. That doesn't work. The address vmpooler.delivery.puppetlabs.net can not be resolved here. Is it maybe an internal address? |
|
@dploeger Sorry, completely missed that. Unfortunately it seems that we don't actually have an image that you can use. The only thing I could think of would be for you to use an outside vagrant image. I'm sorry that I'm not being more use. |
|
@david22swan Maybe you could just paste the test log here. Perhaps that could be enough to lead me in the right direction. |
|
@dploeger Here you go: And here's the debug output: Hope this helps |
|
@david22swan Hm... looks as if /usr/java/xxx isn't the correct path on a RHEL system. Maybe this line happens to be the case not only for CentOS but also for RHEL? Do you perhaps know that? |
|
@dploeger I'm not sure, but it sounds like something that could be right. |
|
@david22swan Changed that. Please try again. |
|
@dploeger Now running clean through the adhoc. :) |
|
I can, sure, but did you know, that you can do that yourself when merging as described here? |
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for installing the Oracle Cryptographic Extensions as requested in MODULES-1681 and adds the appropriate tests.