Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-8698: Fix $install_path on CentOS with tar.gz package type #349

Merged
merged 1 commit into from
Mar 6, 2019
Merged

MODULES-8698: Fix $install_path on CentOS with tar.gz package type #349

merged 1 commit into from
Mar 6, 2019

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Feb 25, 2019

https://tickets.puppetlabs.com/browse/MODULES-8698

When using tar.gz packages on CentOS, the architecture is not part of the name of the installation directory. In this case it's just "jdk1.8.0_201" instead of "jdk1.8.0_201-amd64".

This fix is required to avoid running Exec on every Puppet run when using the following configuration:

java::oracle { 'jdk8':
  basedir => '/mnt'
  java_se => 'jdk'
  version_major => '8u201'
  version_minor => 'b09'
  url_hash => '42970487e3af4f5aa5bca3f542482c60'
  package_type => 'tar.gz'
}

Info: Applying configuration version '1551106786'
Notice: /Stage[main]/Java::Oracle[jdk8]/Exec[Install Oracle java_se jdk 8 8u201 b09]/returns: executed successfully
Notice: Applied catalog in 2.99 seconds

When using tar.gz packages on CentOS, the architecture is not
part of the name of the installation directory. In this case
it's just "jdk1.8.0_201" instead of "jdk1.8.0_201-amd64".
@fraenki fraenki changed the title Fix $install_path on CentOS with tar.gz package type MODULES-8698: Fix $install_path on CentOS with tar.gz package type Feb 28, 2019
@david22swan
Copy link
Member

screen shot 2019-03-06 at 11 56 30 am

@david22swan david22swan merged commit ce348b2 into puppetlabs:master Mar 6, 2019
@david22swan
Copy link
Member

@fraenki Thanks again for putting in the work. :)
Nice to see 2 PRs from one guy in the same day.

@fraenki fraenki mentioned this pull request Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants