Hardening manifests #525
Hardening manifests #525
Conversation
java::adopt is a typethat may have no external impact to Forge modules. java::adoptium is a typethat may have no external impact to Forge modules. java::config is a classthat may have no external impact to Forge modules. java::download is a typeBreaking changes to this file WILL impact these 2 modules (exact match):This module is declared in 79 of 579 indexed public
|
Prior to this commit some commands in our manifest classes would not be up to our code standards. This commit aims to sanitise our code according to our teams best practices.
LukasAud
force-pushed
the
maint-hardening_manifests
branch
from
ad8f8d7 to
cabedbe
Compare
Prior to this commit, multiple unit test cases would fail due to them expecting commands to be run as a single String instead of arrays of commands. This commit aims to fix those test cases by ensuring they mimic the structure of the commands being run on the test cases themselves.
LukasAud
force-pushed
the
maint-hardening_manifests
branch
from
e65ce53 to
b879624
Compare
|
Thanks @ekohl for your suggestions. After carefully testing them, I'm happy enough to implement them into the PR. As for your question, I'm not really sure myself what the difference might be. Maybe someone more veteran, such as @david22swan might be able to help answer that. |
Prior to this commit, a community member had some suggestions to further improve the code This commit aims to implement those suggestions after careful evaluation and testing.
LukasAud
force-pushed
the
maint-hardening_manifests
branch
from
01c3948 to
74ea1de
Compare
Prior to this commit, and after the work performed in [Hardening manifests](#525), the minimum puppet version requirement was expected to be raised up to 6.24.0 to meet logic requirements. This commits aims to fix the missing bump.
Prior to this commit some commands in our manifest classes would not be up to our code standards.
This commit aims to sanitise our code according to our teams best practices.