Support Debian 12 and refactor to make that easier #585
+81
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces variables to make it easier to support multiple versions.
This sets up common contexts for an OS and then runs the tests within those. This avoids duplicating the fact definitions.
3 tasks
bastelfreak
reviewed
Feb 29, 2024
metadata.json
Outdated
| @@ -43,7 +43,8 @@ | |||
| "operatingsystem": "Debian", | |||
| "operatingsystemrelease": [ | |||
| "10", | |||
| "11" | |||
| "11", | |||
| "12" | |||
There was a problem hiding this comment.
How so? Isn't it just because JSON doesn't have trailing commas?
There was a problem hiding this comment.
Mixed space and tabs 😉. Not sure which plugin help me here, maybe "Refined Github"
There was a problem hiding this comment.
BTW it is fixed in the final patch.
There was a problem hiding this comment.
The Debian 12 is not yet supported by Puppet eco-system, so just trying to grab thought that should we revert from metadata?
There was a problem hiding this comment.
Debian 12 packages were released a few days ago?
bastelfreak
approved these changes
Feb 29, 2024
bastelfreak
approved these changes
Feb 29, 2024
praj1001
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the code to make it easier to support multiple versions without copying a lot of code.
Related Issues
It's based on #569
Checklist
puppet apply)