Fix containment of java::config
#609
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0dcd91b the `anchor` pattern was removed, but not replaced with anything and thus broke the containment of `java::config`. This restores the original behaviour by using `contain`. As noted in the code comment, the declaration remains in the same place in the code as evaluation order is important. `java::config` is a private class and relies on variables from the base class's scope having been set before it is evaluated.
bastelfreak
approved these changes
Apr 9, 2025
kenyon
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0dcd91b the
anchorpattern was removed, but not replaced with anything and thus broke the containment ofjava::config. This restores the original behaviour by usingcontain.As noted in the code comment, the declaration remains in the same place in the code as evaluation order is important.
java::configis a private class and relies on variables from the base class's scope having been set before it is evaluated.Also see #543 (comment)