Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-585) allow deferred function for auth password #637

Merged
merged 1 commit into from
Jun 5, 2023
Merged

(CONT-585) allow deferred function for auth password #637

merged 1 commit into from
Jun 5, 2023

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented Jun 2, 2023 •
edited
Loading

  • implementing deferred function for sensitive fields

@Ramesh7 Ramesh7 force-pushed the CONT-585-deferred-function branch 3 times, most recently from 3cb802e to 9d3df96 Compare June 5, 2023 07:58
@Ramesh7 Ramesh7 marked this pull request as ready for review June 5, 2023 08:03
@Ramesh7 Ramesh7 requested a review from a team as a code owner June 5, 2023 08:03
david22swan
david22swan previously approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Happy to merge once my Puppet 8 work is in

@david22swan
Copy link
Member

@Ramesh7 If you could fix the conflict I will merge imeaditly :)

@Ramesh7 Ramesh7 force-pushed the CONT-585-deferred-function branch 2 times, most recently from 3d6deb1 to b05f701 Compare June 5, 2023 12:00
@Ramesh7 Ramesh7 force-pushed the CONT-585-deferred-function branch from b05f701 to 9f9f0eb Compare June 5, 2023 12:40
@david22swan david22swan merged commit 5f02d27 into main Jun 5, 2023
@david22swan david22swan deleted the CONT-585-deferred-function branch June 5, 2023 14:05
waipeng added a commit to waipeng/puppetlabs-kubernetes that referenced this pull request May 28, 2024
@waipeng
Bump min version of stdlib
5a92360 
PR puppetlabs#637 uses stdlib::deferrable_epp that is only available in v8.4.0[1]

[1] puppetlabs/puppetlabs-stdlib#1253

Change-Id: I455cec0ec1c6a2ec63b2ab0c19b2b7a2119f2f26
@waipeng waipeng mentioned this pull request May 28, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramesh7 @david22swan