(PDB-4881) Repack catalog_inputs on PE >= 2019.8.2

[austb]

This should at least wait to merge until we have merged puppetlabs/puppetdb#3335, but may also need to wait until we release 2019.8.2. I don't know the details of this module.

Also I just picked a cron timer, and would love some feedback on it

      weekday => [1,5],
      hour    => 4,
      minute  => 30,

[puppet-community-rangefinder]

pe_databases::maintenance::pg_repack is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[npwalker]

I would probably add this to the existing pg_repack catalogs tables cron job unless we think there's a specific reason it needs to be separated.

you could implement it something like this was when I added resource_events ( when we were still doing reports and resource_events ) ...

https://github.com/puppetlabs/puppetlabs-pe_databases/pull/28/files#diff-16594a284365491882a33bbff5491440R30

However, if there's a reason to keep it separate I'm open to that discussion as well. If it joins to the existing catalogs tables it seems like a good reason to make sure they are all repacked together.

[austb]

Yeah that sounds reasonable to me, I'll update the PR

[MartyEwings]

https://tickets.puppetlabs.com/browse/SUP-2405 may be easier to just push a new PR with the changes nick mentioned

[MartyEwings]

Closing in favor of #54