Skip to content

(SUP-2557) Ensure backup class is not included by default #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

m0dular
Copy link
Contributor

@m0dular m0dular commented Sep 30, 2021

Prior to this commit, by default the pe_databases::backup class would be
included but not do anything. That was because the logic for the class
parameter was correct

disable_maintenance => ! $manage_database_backups

But the logic to include the class was not

if defined('$manage_database_backups')

This commit fixes this logic and adds spec tests to cover it. I also
moved the test for checking the cron resources from an acceptance test
to spec.

Prior to this commit, by default the pe_databases::backup class would be
included but not do anything.  That was because the logic for the class
parameter was correct

disable_maintenance => ! $manage_database_backups

But the logic to include the class was not

if defined('$manage_database_backups')

This commit fixes this logic and adds spec tests to cover it.  I also
moved the test for checking the cron resources from an acceptance test
to spec.
@m0dular m0dular requested a review from a team as a code owner September 30, 2021 20:01
@puppet-community-rangefinder
Copy link

pe_databases is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartyEwings MartyEwings added the bug label Oct 1, 2021
@MartyEwings MartyEwings merged commit 22a7307 into puppetlabs:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants