Skip to content

Fix group letter assignments during upgrade #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Feb 17, 2023
Merged

Fix group letter assignments during upgrade #336

merged 49 commits into from
Feb 17, 2023

Conversation

@timidri
Copy link
Contributor

@timidri timidri commented Feb 16, 2023

This PR changes the following:

  • fix the incorrect group letter assignment in node group configuration for the primary and replica machines
  • add integration test doing a failover and a subsequent upgrade

@timidri
code layout
8e59121
@timidri
code layout
5827944
@timidri
typo
6b25eba
@timidri
docs and formatting
f43e363
@timidri
formatting
93a212e
@timidri
formatting
18c851c
@timidri
add perform_failover spec plan
acbef6b
@timidri
output error when rbac token request fails
85a3334
@timidri
fix failover test plan and GA
ab85bc9
@timidri
fix architecture
64b0322
@timidri
fix provision
3a3b3ef
@timidri
fix architecture
331a810
@timidri
swap primary and replica; correct params
4c29ac5
@timidri
add trace
6ad3cd0
@timidri
add logging
87c16ad
@timidri
revert back to using targets
c826700
@timidri
formatting
26d7e17
@timidri
use .name to convert target to string
437cf23
@timidri
change name to uri
3e7955e
@timidri
debugging
6f06cab
@timidri
debugging
bf027cd
@timidri
fix
04611f6
@timidri
remove certname() call
249364c
@timidri
purge failed primary before promoting
54970a8
@timidri
fix
0b0a707
@timidri
moving purge to after promote
7374797
@timidri
add timeout 0 to shutdown command
b041010
@timidri
destroy ssldir, use infra forget
9531601
@timidri
disable start of networking on failed primary
ee9de3f
@timidri
generate rbac token before infra forget
12bab14
@timidri timidri added the bugfix label Feb 16, 2023
@timidri timidri requested a review from a team as a code owner February 16, 2023 16:59
davidsandilands
davidsandilands approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@davidsandilands davidsandilands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timidri timidri merged commit 8fb38b5 into main Feb 17, 2023
@timidri timidri deleted the SOLARCH-674 branch February 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidsandilands davidsandilands davidsandilands approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timidri @davidsandilands