Skip to content

Conversation

@bastelfreak
Copy link
Collaborator

The install.bash script from PE supports agent updates and upgrades since a long time. I don't see a reason why the task in peadm should abort if it isn't a new installation. I understand if the support team doesn't want to take responsibility for upgrades/updates, but I think we shouldn't block users/SDP consultants using it.

@bastelfreak bastelfreak requested a review from a team as a code owner April 14, 2023 11:00
Copy link
Contributor

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't see a problem with this. @ody do you?

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AaronShannon
Copy link
Contributor

Hi @bastelfreak

Can you please rebase your branch with the latest from main? That way we can rekick the CLI checks since the previously run checks have now expired

The install.bash script from PE supports agent updates and upgrades
since a long time. I don't see a reason why the task in peadm should
abort if it isn't a new installation. I understand if the support team
doesn't want to take responsibility for upgrades/updates, but I think we
shouldn't block users/SDP consultants using it.
@bastelfreak
Copy link
Collaborator Author

@AaronShannon done

@AaronShannon AaronShannon merged commit 72003c6 into puppetlabs:main Sep 19, 2023
@bastelfreak bastelfreak deleted the agent_update branch August 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants