Fix for plan peadm::add_compiler over pcp transport #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
There are a lot of changes since this PR was created, can you please rebase it? |
CoMfUcIoS
reviewed
Sep 15, 2023
Contributor
Author
|
@CoMfUcIoS As requested I have rebased my branch |
ragingra
approved these changes
Oct 9, 2023
Contributor
ragingra
left a comment
ragingra
left a comment
There was a problem hiding this comment.
Looks good! Tested the the add compiler plan and worked over pcp
CoMfUcIoS
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan
peadm::add_compilerhas been updated to make use of thepeadm::subplans::component_installso that it doesn't error when run over PCP transport. This also makes the management of the agent installation consistent withpeadm::add_databaseandpeadm::add_replicaplans.In addition, updates were made to
peadm::subplans::component_installas the trusted facts set for compilers are different to other Puppet infrastructure roles and updates were made topeadm::subplan::agent_installto add dns-alt-names to the certificate if provided.Closes #355