Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-39307) Legacy compilers support smoke tests #505

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Conversation

CoMfUcIoS
Copy link
Contributor

@CoMfUcIoS CoMfUcIoS commented Sep 26, 2024

Summary

  • Install Puppet Enterprise with legacy compilers
  • Convert one compiler to legacy and verify the conversion

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

…to legacy

- Trigger on pull requests affecting specific paths and on manual dispatch
- Provision and set up a test cluster using Bolt and Rake
- Install Puppet Enterprise on the test cluster
- Convert one compiler to legacy and verify the conversion
- Tear down the test cluster after the workflow completes
…acy compilers

- Trigger on pull requests affecting specific paths and on manual dispatch
- Provision and set up a test cluster using Bolt and Rake
- Install Puppet Enterprise with legacy compilers on the test cluster
- Verify the configuration of legacy compilers
- Upgrade Puppet Enterprise and verify the configuration post-upgrade
- Tear down the test cluster after the workflow completes
…es plan

- Replace parallelize with map for better readability
- Add error handling for hostname command execution
- Add error handling for inventory file update command
…de.yaml

- Replace `head -n 2` with `sed -n 2p` for accurate selection of the second compiler
The push trigger has been removed from the test-legacy-compilers and test-legacy-upgrade workflows. This change ensures that these workflows are only triggered manually via workflow_dispatch.

fix(workflow): correct conditional syntax in test-legacy-upgrade.yaml

- Replace incorrect `AND` with `&&` for accurate conditional checks
@CoMfUcIoS CoMfUcIoS requested review from a team as code owners September 26, 2024 11:01
@CoMfUcIoS CoMfUcIoS merged commit 4596a6c into main Sep 26, 2024
71 checks passed
@CoMfUcIoS CoMfUcIoS deleted the legacy_tests branch September 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants