-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python package name in RHEL/CentOS 8 #1316
Conversation
postgresql::params is a classthat may have no external impact to Forge modules. This module is declared in 70 of 578 indexed public
|
Probably do release major >= 8 or the same issue will be present in 9 |
In RHEL/CentOS8, python3 is used globally instead of python2. Because of that python-* package is no longer available and most of python packages are named python3-*.
That is definitely better. I updated the change accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I started the tests.
@@ -109,7 +109,11 @@ | |||
$psql_path = pick($psql_path, "${bindir}/psql") | |||
|
|||
$perl_package_name = pick($perl_package_name, 'perl-DBD-Pg') | |||
$python_package_name = pick($python_package_name, 'python-psycopg2') | |||
if $facts['os']['family'] == 'RedHat' and versioncmp($facts['os']['release']['major'], '8') >= 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking out loud: this will also cover Fedora. It will break Fedora versions which are still primarily Python 2 but those are EOL anyway. Probably not a big deal.
Test failures look like timeouts, ignoring those. |
In RHEL/CentOS8, python3 is used globally instead of python2. Because
of that python-* package is no longer available and most of python
packages are named python3-*.