Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: correct postgresql_conn_validator example #1332

Merged
merged 1 commit into from
May 25, 2022

Conversation

bastelfreak
Copy link
Collaborator

it's required to set the psql_path parameter. Otherwise you end up with
something like:

Debug: Executing: '--tuples-only --quiet --no-psqlrc --host 127.0.0.1
--port 5432 --username grafana --dbname grafana --command SELECT 1'

it's required to set the psql_path parameter. Otherwise you end up with
something like:
```
Debug: Executing: '--tuples-only --quiet --no-psqlrc --host 127.0.0.1
--port 5432 --username grafana --dbname grafana --command SELECT 1'
```
@bastelfreak bastelfreak requested a review from a team as a code owner March 23, 2022 22:59
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A valid default value would be better, but at least show that it does not exist! LGTM!

@bastelfreak
Copy link
Collaborator Author

@smortex I totally agree. I was really surprised to find out that there isn't. Maybe there was one in the past 🤔

@ekohl
Copy link
Collaborator

ekohl commented Mar 25, 2022

Doesn't look like it ever had a default.
c37b50c
I wouldn't mind one, or it could be modified to use $PATH by default.

@github-actions
Copy link

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

@kenyon
Copy link
Contributor

kenyon commented May 25, 2022

Bad @github-actions bot.

@david22swan david22swan merged commit 3325703 into puppetlabs:main May 25, 2022
@david22swan
Copy link
Member

@bastelfreak Apologies on the wait but this LGTM so have gone ahead and merged.
Thank's for your contribution :)

@pmcmaw pmcmaw added the bugfix label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants