Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-1352) - Updating postgresql service version on SLES #1353

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Jul 20, 2022

Fixes #1352
Updating postgresql service package version to be inline with https://zypp.postgresql.org/howtozypp/

@pmcmaw pmcmaw requested a review from a team as a code owner July 20, 2022 08:43
@CLAassistant
Copy link

CLAassistant commented Jul 20, 2022

CLA assistant check
All committers have signed the CLA.

@pmcmaw pmcmaw force-pushed the GH-1352/main/add_postgres_zypper branch 5 times, most recently from b5ad282 to 518974e Compare July 20, 2022 10:31
@ekohl
Copy link
Collaborator

ekohl commented Jul 20, 2022

When I experiment I sometimes drop all unrelated OSes from metadata.json to speed up CI/waste fewer resources.

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Jul 20, 2022

@ekohl great shout! Completely forgot you could do that.
Suppose that is what 10 months of maternity leave does to your brain. Thank you :-)

@ekohl
Copy link
Collaborator

ekohl commented Jul 20, 2022

In that case, welcome back :) And if you're in Europe, you can also blame it on the temperature.

@pmcmaw pmcmaw force-pushed the GH-1352/main/add_postgres_zypper branch from deecc58 to 9977bf2 Compare July 20, 2022 13:09
@pmcmaw pmcmaw changed the title (WIP) - Experimenting (GH-1352) - Updating postgresql service version to enable installation on SLES Jul 20, 2022
@pmcmaw pmcmaw changed the title (GH-1352) - Updating postgresql service version to enable installation on SLES (GH-1352) - Updating postgresql service version on SLES Jul 20, 2022
@chelnak
Copy link
Contributor

chelnak commented Jul 20, 2022

Looks good thank you @pmcmaw

Comment on lines +230 to 232
/12\.[4-5]/ => '12',
/15\.[0-9]/ => '14',
default => '96',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know SLES. Are point releases also supported? Is this really valid for 15.0 as well or was it only introduced in some later 15.x version?

@chelnak chelnak merged commit 0378093 into puppetlabs:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLES Acceptance test failures
4 participants