Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 14/16/17: Drop code leftovers #1388

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

bastelfreak
Copy link
Collaborator

This was previously done in
#1331.

@bastelfreak bastelfreak self-assigned this Jan 26, 2023
@bastelfreak bastelfreak requested a review from a team as a code owner January 26, 2023 10:26
@puppet-community-rangefinder
Copy link

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 70 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, https://endoflife.software/operating-systems/unix-like-bsd/openbsd says we can also clean that up. And https://endoflife.date/sles also says SLES 11 is EOL. I never bothered with these cleanups since it's barely any overhead to keep it in. It'll start getting interesting if you can actually drop code to support older PostgreSQL. Might be interesting to see if there's any PG < 9.3 code for example.

@bastelfreak
Copy link
Collaborator Author

yep. I want to do some more cleanups. At the moment I was focused on stuff that's already deprecated, so we can drop it without a major release.

@bastelfreak
Copy link
Collaborator Author

some of the nightlys tend to timeout. all important tests succeeded.

@bastelfreak bastelfreak merged commit ac64c23 into puppetlabs:main Jan 26, 2023
@bastelfreak bastelfreak deleted the ubuntu18 branch January 26, 2023 11:16
@chelnak chelnak added the bugfix label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants