Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql::server: Remove deprecated version parameter #1482

Merged
merged 1 commit into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions REFERENCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,6 @@ The following parameters are available in the `postgresql::server` class:
* [`backup_enable`](#-postgresql--server--backup_enable)
* [`backup_options`](#-postgresql--server--backup_options)
* [`backup_provider`](#-postgresql--server--backup_provider)
* [`version`](#-postgresql--server--version)
* [`extra_systemd_config`](#-postgresql--server--extra_systemd_config)
* [`auth_host`](#-postgresql--server--auth_host)
* [`auth_local`](#-postgresql--server--auth_local)
Expand Down Expand Up @@ -1374,14 +1373,6 @@ Specifies the backup provider to use.

Default value: `$postgresql::params::backup_provider`

##### <a name="-postgresql--server--version"></a>`version`

Data type: `Optional[String[1]]`

Deprecated. Use postgresql::globals instead. Sets PostgreSQL version

Default value: `undef`

##### <a name="-postgresql--server--extra_systemd_config"></a>`extra_systemd_config`

Data type: `Optional[String]`
Expand Down
12 changes: 1 addition & 11 deletions manifests/server.pp
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@
# @param backup_options A hash of options that should be passed through to the backup provider.
# @param backup_provider Specifies the backup provider to use.
#
# @param version Deprecated. Use postgresql::globals instead. Sets PostgreSQL version
#
# @param extra_systemd_config
# Adds extra config to systemd config file, can for instance be used to add extra openfiles. This can be a multi line string
# @param auth_host auth method used by default for host authorization
Expand Down Expand Up @@ -192,19 +190,11 @@
Boolean $backup_enable = $postgresql::params::backup_enable,
Hash $backup_options = {},
Enum['pg_dump'] $backup_provider = $postgresql::params::backup_provider,

#Deprecated
Optional[String[1]] $version = undef,
) inherits postgresql::params {
if $port =~ String {
deprecation('postgres_port', 'Passing a string to the port parameter is deprecated. Stdlib::Port will be the enforced datatype in the next major release')
}
if $version != undef {
warning('Passing "version" to postgresql::server is deprecated; please use postgresql::globals instead.')
$_version = $version
} else {
$_version = $postgresql::params::version
}
$_version = $postgresql::params::version

if $createdb_path != undef {
warning('Passing "createdb_path" to postgresql::server is deprecated, it can be removed safely for the same behaviour')
Expand Down