Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Valid Until Date #1624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mooreandrew
Copy link

Summary

I have a requirement to set valid until dates for roles that I need to manage via this puppet postgresql module. This change adds support for setting a valid_until attribute for a role.

Related Issues (if any)

None

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

This allows for the valid until attribute to be set on roles.
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2024

CLA assistant check
All committers have signed the CLA.

@smortex
Copy link
Collaborator

smortex commented Dec 24, 2024

See CI failures about missing documentation. Also, adding tests to spec/defines/server/role_spec.rb to ensure the feature don't break in the future would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants