(MODULES-10120) enable simplecov; update to PDK 1.14.1; minor cleanups

[DavidS]

This PR was created using this script in stages running pdk update and committing individual changes in multiple iterations. Some manual fixes interspersed to reduce aberrations.

#! /usr/bin/ruby
require 'yaml'

contents = YAML.load(File.read(".sync.yml"))

contents[".gitlab-ci.yml"] = {'delete' => true}
contents["spec/spec_helper.rb"] ||= {}
contents["spec/spec_helper.rb"]['coverage_report'] = true

gitignore = contents[".gitignore"] ||= {}
gitignore["required"] ||= []
gitignore["required"] -= ["---.project"]
gitignore.delete("required") if gitignore["required"].empty?
contents.delete(".gitignore") if contents[".gitignore"].empty?

contents.delete("spec/default_facts.yml") if contents["spec/default_facts.yml"] == {"unmanaged" => true}

[".travis.yml", "appveyor.yml"].each do |f|
  contents[f] ||= {}
  if contents[f]["unmanaged"] != true && contents[f]["delete"] != true
    contents[f]["simplecov"] = true
  end
end

contents = Hash[contents.keys.sort{|a,b| a.upcase <=> b.upcase}.map{|k| [k, contents[k]]}]
File.open(".sync.yml", "w") { |file| file.write(contents.to_yaml(line_width: 200)) }

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@d15af63). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #268   +/-   ##
=======================================
  Coverage          ?     0%           
=======================================
  Files             ?      2           
  Lines             ?    183           
  Branches          ?      0           
=======================================
  Hits              ?      0           
  Misses            ?    183           
  Partials          ?      0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15af63...125ac5a. Read the comment docs.

[glennsarti]

@DavidS Can you please re-add the comments as to why Travis CI and Appveyor are not managed by this module

https://github.com/puppetlabs/puppetlabs-powershell/pull/268/files#diff-f620401c6bdf661e1275316a6e01b62fL29

https://github.com/puppetlabs/puppetlabs-powershell/pull/268/files#diff-f620401c6bdf661e1275316a6e01b62fL33