(PE-12299) Pass Puppet agent PID as an argument

Similar to the improvement made for the Windows install script, pass the
Puppet agent PID as an argument to the solaris service script. This
prevents recreating the file every Puppet run.

templates/solaris_start_puppet.sh.erb → files/solaris_start_puppet.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-puppet_pid="<%= @puppet_agent_pid %>"
+puppet_pid=$1
 while $(kill -0 ${puppet_pid:?}); do
   sleep 5
 done

manifests/service/solaris.pp

@@ -15,12 +15,12 @@
     }
   } elsif $::operatingsystem == 'Solaris' and $::operatingsystemmajrelease == '11' {
     file { '/tmp/solaris_start_puppet.sh':
-      ensure  => file,
-      content => template('puppet_agent/solaris_start_puppet.sh.erb'),
-      mode    => '0755',
+      ensure => file,
+      source => 'puppet:///modules/puppet_agent/solaris_start_puppet.sh',
+      mode   => '0755',
     } ->
     exec { 'solaris_start_puppet.sh':
-      command => '/tmp/solaris_start_puppet.sh &',
+      command => "/tmp/solaris_start_puppet.sh ${::puppet_agent_pid} &",
       path    => '/usr/bin:/bin:/usr/sbin',
     }
     file { ['/var/opt/lib', '/var/opt/lib/pe-puppet', '/var/opt/lib/pe-puppet/state']: