Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-3571) Allow setting install_path for MSI #130

Merged
merged 1 commit into from
Jul 18, 2016

Conversation

MikaelSmith
Copy link
Contributor

Allow setting the INSTALLDIR option for the Windows MSI.

####`install_dir`

The directory the puppet agent should be installed to. This is only applicable for windows operating systems.
This only applies to an agent upgrade and will not change an already installed agent.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Renelast I'm not quite sure what you meant by this last sentence.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikaelSmith I meant to say that setting the install_dir option will not reinstall an agent package to a new directory. This setting only has effect if the agent on the client is being updated. Does that make any sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks. I'm going to tweak the wording slightly to This only applies when upgrading the agent to a new version; it will not cause re-installation of the same version to a new location.

Allow setting the INSTALLDIR option for the Windows MSI.
@MikaelSmith
Copy link
Contributor Author

@Iristyle @highb mind giving this a review?

@highb
Copy link
Contributor

highb commented Jul 18, 2016

👍 from me

@highb highb merged commit 2b9d44d into puppetlabs:master Jul 18, 2016
@MikaelSmith MikaelSmith deleted the MODULES-3571 branch July 18, 2016 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants