(MODULES-3994) Fix incorrect condition so services are created #182
Conversation
|
Hello, I'm reasonably sure that the fix is valid - but I've exhausted my time budget for working out the unit tests today. If I can get some time next week I'll give it another try, but this seems like a fairly serious bug because it results in services not getting installed so maybe someone else can have a look. |
|
@seanhoughton thank you for filing this! I created a ticket, https://tickets.puppetlabs.com/browse/MODULES-3994, to track resolution of this. Agreed this bug needs fixed |
|
I'm not sure why the 4.0.0 tests are failing but I'm suspicious of the version comparisons. All the tests pass for me locally running inside a container...
|
| @@ -109,7 +109,7 @@ def global_facts(facts, os) | |||
| end | |||
| end | |||
|
|
|||
| [{}, {:service_names => []}].each do |params| | |||
| [{}, {}].each do |params| | |||
There was a problem hiding this comment.
Why run this twice now? This was also meant to test with services managed and unmanaged.
There was a problem hiding this comment.
You're right and I've just restored the params
|
Tests are failing. Is that something you're looking into? |
MikaelSmith
changed the title
|
Waiting for CLA signature by @seanhoughton @seanhoughton - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html |
|
CLA signed by all contributors. |
|
Fixed up in #209. |
This fixes a typo that prevents the service resources from being created