Use getvar for facts that doesn't exist in my environment #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highb
approved these changes
Dec 21, 2016
highb
suggested changes
Dec 21, 2016
There was a problem hiding this comment.
@TomaszUrugOlszewski Could you amend the commit titles to include MODULES-3710 so we can track this fix as part of the wider effort we're working on to work with strict_variables? Thanks.
|
@highb we can use 'squash and merge' to fix up the commit title. |
highb
approved these changes
Dec 21, 2016
|
@MikaelSmith 👍 on that plan from me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing those 3 facts puppet module started to work with strict_variables set to true