(MODULES-4214) Add additional installation parameters during upgrade #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
MikaelSmith
suggested changes
Jan 9, 2017
| {:install_options => ['OPTION1=value1','OPTION2=value2'],}) | ||
| } | ||
|
|
||
| it { is_expected.to compile.with_all_deps } |
There was a problem hiding this comment.
This test doesn't seem to be working right.
There was a problem hiding this comment.
Still a work in progress. Running spec test on Windows is difficult for this module.
glennsarti
force-pushed
the
ticket/master/MODULES-4214-add-install-params
branch
from
b8883fb to
dd906b9
Compare
|
Rebased all the bad commit messages. Still need to update the Readme |
glennsarti
force-pushed
the
ticket/master/MODULES-4214-add-install-params
branch
from
dd906b9 to
d65162a
Compare
glennsarti
changed the title
|
Is this finished? Didn't realize it'd been updated. |
MikaelSmith
reviewed
Jan 30, 2017
README.markdown
Outdated
| @@ -151,6 +151,14 @@ The directory the puppet agent should be installed to. This is only applicable f | |||
| install_dir => 'D:\Program Files\Puppet Labs' | |||
| ``` | |||
|
|
|||
| ##### `install_options` | |||
|
|
|||
| An array of additional options to pass when installing a package. These options are package-specific, and should be documented by the software vendor. One commonly implemented option is `INSTALLDIR` Each option in the array can either be a string or a hash, where each key and value pair are interpreted in a provider specific way. Each option will automatically be quoted when passed to the install command. With Windows packages, note that file paths in an install option must use backslashes. (Since install options are passed directly to the installation command, forward slashes won't be automatically converted like they are in `file` resources.) Note also that backslashes in double-quoted strings _must_ be escaped and backslashes in single-quoted strings _can_ be escaped. | |||
There was a problem hiding this comment.
Since we control the package, shouldn't we just point to where these options are defined (rather than say they "documented by the software vendor")?
There was a problem hiding this comment.
Whoops. Copy-pasta fail from the package provider
glennsarti
force-pushed
the
ticket/master/MODULES-4214-add-install-params
branch
from
d65162a to
975343d
Compare
|
@MikaelSmith Documentation updated. |
MikaelSmith
reviewed
Feb 4, 2017
manifests/init.pp
Outdated
| @@ -35,6 +35,18 @@ | |||
| # The directory the puppet agent should be installed to. This is only applicable for | |||
| # windows operating systems. This only applies when upgrading the agent to a new | |||
| # version; it will not cause re-installation of the same version to a new location. | |||
| # [install_options] | |||
| # An array of additional options to pass when installing a package. These | |||
There was a problem hiding this comment.
Nice pickup. Thanks. Fixed.
Previously it was not possible to pass additional installation parameters during an upgrade process. In the case of MSI files this could be sensitive passwords or other public MSI properties. In the case of package resources, additional options could not be added to the package resource. This commit adds a parameter called `install_options` which mirrors the `install_options` parameter from the package resource and then passes this down so that it is invoked on installation (either by a package resource or in the batch file to install the MSI)
glennsarti
force-pushed
the
ticket/master/MODULES-4214-add-install-params
branch
from
975343d to
458a747
Compare
MikaelSmith
approved these changes
Feb 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to pass additional installation parameters during
an upgrade process. In the case of MSI files this could be sensitive passwords
or other public MSI properties. In the case of package resources, additional
options could not be added to the package resource.
This commit adds a parameter called
install_optionswhich mirrors theinstall_optionsparameter from the package resource and then passes this downso that it is invoked on installation (either by a package resource or in the
batch file to install the MSI)