(MODULES-5953) Adds ability to set stringify_facts #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelSmith
reviewed
Nov 8, 2017
manifests/prepare/stringify_facts.pp
Outdated
| } | ||
|
|
||
| } else { | ||
| fail('The puppet_agent::prepare::stringify_facts class should only be run on Puppet < 4') |
There was a problem hiding this comment.
This approach is slightly awkward, because it means you have to apply this class, then remove it and apply puppet_agent to upgrade. Letting it be a warning might be slightly friendlier.
There was a problem hiding this comment.
Yeah, I thought the stringify_facts setting would throw an error with Puppet 4, but it's just ignored, so I'll switch this to a warning 👍
|
CLA signed by all contributors. |
* `stringily_facts` is currently not configurable in the module * Lets add a class to configure it * AND add docs on using the `puppet_conf` task to Do it
petems
force-pushed
the
MODULES-5953-add_stringify_facts_class_and_docs
branch
from
8fc3dfe to
760eca1
Compare
|
@MikaelSmith Fixed to a warning 👍 |
|
@branan care if we include this in the next release? We could hold off while we do a bugfix release, then plan to add it in a later feature release. But it only applies to people starting on Puppet 3, so I'd rather get it out sooner if we're going to do it at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringify_factsis currently not configurablein the module
puppet_conftask toDo it