(PE-23563) Stop MCO and Puppet prior to MSI install #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was possible to get into a strange race condition where the MSI was able to propertly stop the MCollective service prior to upgrade. This commit attempts to stop the mco service prior to the MSI being invoked, giving the service more time to stop correctly.
Previously it was possible to get into a strange race condition where the MSI was able to propertly stop the Puppet Agent service prior to upgrade. This commit attempts to stop the puppet service prior to the MSI being invoked, giving the service more time to stop correctly.
Previously it was difficult to debug failed upgrades as it was not possible to know what rights the installation user had at install time. This commit logs the current user's rights prior to the upgrade.
|
This PR is based on the work by @Iristyle on https://github.com/iristyle/puppetlabs-puppet_agent/tree/PE-23563-tests |
|
CLA signed by all contributors. |
|
Is CI fixed with the other PR? |
|
This PR seems fine. |
|
Rerunning Travis CI... |
|
Travis is now green but Jenkins is Red due to some other issue. |
|
I'm a bit surprised that we were able to merge a PR using a PE ticket number, since those tickets are private / not searchable.... we have taken lengths in other projects to making sure we use public tickets for public / open source projects like this module. That said, I see some prior art in the PR merge history... but we should probably be a bit more careful about this in the future. |
|
@Iristyle Whoops true. I shall remember that for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to get into a strange race condition where the MSI
was able to propertly stop the MCollective and Puppet service prior to upgrade. This
PR attempts to stop the mco and puppet services prior to the MSI being invoked, giving
the service more time to stop correctly.
This PR also adds some helpful information into the installation log for use during debugging failed installations.