Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-7329) Fix update failure for FIPS #295

Merged
merged 1 commit into from
Jun 19, 2018

Conversation

smcclellan
Copy link
Contributor

When the upgrade was attempted, the update command would not run
because it was looking for the wrong package name (el7 vs. redhatfips7).
This updates the name of the package to update to redhatfips7.

@smcclellan
Copy link
Contributor Author

Fixing spec tests now.

@caseywilliams
Copy link
Contributor

@smcclellan I've retargeted this at 1.x -- would you mind rebasing?

@smcclellan smcclellan changed the base branch from 1.x to master June 14, 2018 22:53
@smcclellan smcclellan changed the base branch from master to 1.x June 14, 2018 22:53
@smcclellan
Copy link
Contributor Author

@caseywilliams Rebased.

@puppetcla
Copy link

CLA signed by all contributors.

@ScottGarman
Copy link
Contributor

👍

@glennsarti
Copy link
Contributor

glennsarti commented Jun 18, 2018

Should this really be targetted at 1.x? 1.x branch is deprecated and has known issues in the wild.

@branan
Copy link
Contributor

branan commented Jun 18, 2018

@glennsarti I've been considering 1.x the "live" branch and master to be "WIP" until we have the tests passing and a plan to actually cut a 2.0 release.

@smcclellan
Copy link
Contributor Author

Move this to a MODULES ticket.

When the upgrade was attempted, the update command would not run
because it was looking for the wrong package name (el7 vs. redhatfips7).
This updates the name of the package to update to redhatfips7.
@smcclellan smcclellan changed the title (PE-24301) Fix update failure for FIPS (MODULES-7329) Fix update failure for FIPS Jun 19, 2018
@mcdonaldseanp mcdonaldseanp merged commit 7bea2e4 into puppetlabs:1.x Jun 19, 2018
@smcclellan smcclellan deleted the redhatfips7 branch June 19, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants