(maint) Use BKR-314 and BKR-317 fixes #32
Conversation
| install_package host, 'puppet' | ||
| add_foss_defaults_on host | ||
| add_puppet_paths_on host | ||
| install_puppet_on host |
There was a problem hiding this comment.
We should be adding options here for version and architecture for windows users?
https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/spec/spec_helper_acceptance.rb#L7 as well as version numbers.
Also the above step method should be removed as this has been yanked for beaker-rspec
There was a problem hiding this comment.
All the step methods should be removed, but I hadn't heard they were officially yanked from beaker-rspec.
Anything that needs to be added for Windows would happen under PUP-4479.
MikaelSmith
force-pushed
the
maint/master/use-BKR-317-314
branch
from
e2e5e0e to
6d1ebf0
Compare
MikaelSmith
changed the title
MikaelSmith
force-pushed
the
maint/master/use-BKR-317-314
branch
from
6d1ebf0 to
3cc230d
Compare
MikaelSmith
changed the title
MikaelSmith
force-pushed
the
maint/master/use-BKR-317-314
branch
from
3cc230d to
027a279
Compare
BKR-314 and BKR-317 identified issues with using Beaker helpers for upgrade scenarios. Simplify the acceptance setup by using Beaker helpers now that they're fixed.
Using `step` with beaker-rspec is frowned-upon. Remove it and use `puts` instead.
Ensure sudo is not used so we use TravisCI container-based builds.
MikaelSmith
force-pushed
the
maint/master/use-BKR-317-314
branch
from
027a279 to
c754bb1
Compare
MikaelSmith
changed the title
|
@ericwilliamson mind taking a look over this and merging if it looks good? Jenkins tests are broken because of Beaker 2.16, and this fixes them. |
| @@ -11,6 +11,6 @@ group :test do | |||
| end | |||
|
|
|||
| group :system_tests do | |||
| gem 'beaker', '~> 2.14' | |||
| gem 'beaker', '~> 2.15' | |||
There was a problem hiding this comment.
you mention it's broken for beaker 2.16, should we be pinning to that instead of 2.15 as the minimum version?
There was a problem hiding this comment.
The behavior changed, so that makes sense.
MikaelSmith
force-pushed
the
maint/master/use-BKR-317-314
branch
from
c754bb1 to
da92f18
Compare
Beaker 2.16 requires the `puppet_agent_version` is set for `install_puppet_agent_on`. Set to the latest puppet-agent version. [skip ci] no effect on TravisCI
MikaelSmith
force-pushed
the
maint/master/use-BKR-317-314
branch
from
da92f18 to
58b1d74
Compare
|
👍 |
(maint) Use BKR-314 and BKR-317 fixes
BKR-314 and BKR-317 identified issues with using Beaker helpers for
upgrade scenarios. Simplify the acceptance setup by using Beaker helpers
now that they're fixed.
Beaker 2.15 was released with fixes for BKR-314 and BKR-317.