(MODULES-8319) Update service to exclude MCO for puppet > 6 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
mcdonaldseanp
force-pushed
the
MODULES8319
branch
2 times, most recently
from
9158fcc to
06994c6
Compare
added 2 commits
January 25, 2019 16:12
Packages from the puppet6 collections (and moving forward from that) we no longer carry the mcollective service. So for upgrades to collections other than puppet5 and PC1 we should ignore the mcollective service. This commit updates the service logic to use a new $_service_names parameter that is updated to exclude mcollective with anything that is not collections puppet5 or PC1
mcdonaldseanp
changed the title
speedofdark
approved these changes
Jan 28, 2019
caseywilliams
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we removed the mcollective service in puppet6 collections, we need to update the services management to not attempt to start mco after upgrade.