(MODULES-4730) Do not pass the agent environment during MSI installs #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the MSI installer already preserves the environment of an existing agent install, there's no need to specify it. Additionally, when there is no 'environment' key present in puppet.conf, this would set the environment key to the default value 'production', which can cause nodes to be incorrectly classified after upgrades.
|
It looks like there may be a related PR at #364 |
|
CLA signed by all contributors. |
mcdonaldseanp
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the MSI installer already preserves the environment of an existing
agent install, there's no need to specify it. Additionally, when there is
no 'environment' key present in puppet.conf, this would set the environment
key to the default value 'production', which can cause nodes to be
incorrectly classified after upgrades.