(PA-2385) Update service management to run always for windows #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previosly, we only managed services on failure in the powershell script for agent upgrades. Service management for successes were done through the MSI and then through a subsequent puppet run (for pxp-agent service management). This commit updates the script to also manage services in the upgrade script (i.e. actually manage service startup for pxp-agent/puppet in the script rather than relying on puppet to be available). This should alleviate concerns around the initial puppet run failing (and thus leaving pxp-agent off) after upgrades
mcdonaldseanp
force-pushed
the
PA2385
branch
8 times, most recently
from
02fadfb to
9ee5403
Compare
This commit updates the install_puppet.ps1 script to a file resource rather than a template.
speedofdark
approved these changes
Feb 26, 2019
| [String] $PuppetMaster='<%= @_puppet_master %>', | ||
| [String] $PuppetStartType='<%= @_agent_startup_mode %>', | ||
| [String] $InstallArgs='<%= @_install_options %>', | ||
| [String] $InstallScriptPIDFile='<%= @_install_pid_file_loc %>', |
There was a problem hiding this comment.
This isn't in the PS based set of args? Is that on purpose? From reading below, it looks like you removed the need for it, but wanted to double check.
There was a problem hiding this comment.
yeah, there's no need for this param anymore
| # When the MSI installargs parameter is passed to the powershell script it's inside | ||
| # a cmd.exe instance, so we need to escape the quotes correctly so they show up as | ||
| # plaintext double quotes to the powershell command. (To correctly escape to a | ||
| # plaintext " you use three "'s in cmd.exe) |
There was a problem hiding this comment.
I hate cross boundary quoting. A lot.
| # The powershell execution uses -Command and not -File because -File will interpolate the quotes | ||
| # in a context like cmd.exe: https://docs.microsoft.com/en-us/powershell/scripting/components/console/powershell.exe-command-line-help?view=powershell-6#-file-- | ||
| # Because of this it's much cleaner to use -Command and use single quotes for each powershell param | ||
| command => "${::system32}\\cmd.exe /S /c start /b ${::system32}\\WindowsPowerShell\\v1.0\\powershell.exe \ |
There was a problem hiding this comment.
Our community will truly appreciate your commentary.
caseywilliams
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.