(MODULES-8554) Add error reporting for background upgrades #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonaldseanp
force-pushed
the
MODULES8554
branch
4 times, most recently
from
2f0cc19 to
a155ca7
Compare
|
CLA signed by all contributors. |
mcdonaldseanp
force-pushed
the
MODULES8554
branch
3 times, most recently
from
a75c49c to
96cb3ef
Compare
caseywilliams
approved these changes
Mar 5, 2019
mcdonaldseanp
force-pushed
the
MODULES8554
branch
4 times, most recently
from
768b701 to
1c97903
Compare
caseywilliams
approved these changes
Mar 11, 2019
speedofdark
approved these changes
Mar 11, 2019
| not File.exists?(logfile) | ||
| end | ||
|
|
||
| def delete_file_and_read_content(filename) |
There was a problem hiding this comment.
Nit: swap order of verbs? Since we're reading it, then deleting it?
This commit adds a new type/provider to check for an error log from a previous installation and fail if the error log exists. This will allow upgrades to leave behind error logs on failure to indicate the next puppet run should not perform the upgrade since the previous one failed. The provider will delete the existing error log before failing so that after the failed puppet run the user can attempt the upgrade again. This should provide error reporting for upgrades that require background processes (i.e. windows upgrades) by failing the next puppet run after the upgrade failure.
mcdonaldseanp
force-pushed
the
MODULES8554
branch
from
1c97903 to
334df55
Compare
mcdonaldseanp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.