(MODULES-8720) Update source calculation to prefer source user param #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource If the user specifies the source parameter to the overall puppet_agent module then we should prefer that setting to anything calculated in the osfamily classes. This commit updates those classes to prefer $::puppet_agent::source if it's available.
caseywilliams
approved these changes
Mar 5, 2019
|
CLA signed by all contributors. |
Since we broke the source parameter, so did our spec testing. This commit updates the spec testing to correctly test for situations where the source parameter is provided by the user (and therefore overrides any source calc)
mcdonaldseanp
force-pushed
the
MODULES8720
branch
from
2b5dfe0 to
9121032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.