Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yum URL path for RedHat systems still using the PC1 collection #400

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix Yum URL path for RedHat systems still using the PC1 collection #400

merged 1 commit into from
May 13, 2019

Conversation

coreone
Copy link
Contributor

@coreone coreone commented Apr 10, 2019

Currently, if you have a RedHat-based machine and you specify the PC1 collection, you get a yum repository configuration with the source set to:

http://yum.puppet.com/PC1/el/6/x86_64

However, the correct URL should be:

http://yum.puppet.com/el/6/PC1/x86_64

This PR fixes the source to use the correct URL if PC1 is the collection being used.

@coreone coreone changed the title Fix Yum URL path for RedHat systems Fix Yum URL path for RedHat systems still using the PC1 collection Apr 10, 2019
@puppetcla
Copy link

Waiting for CLA signature by @coreone

@coreone - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

@coreone
Copy link
Contributor Author

coreone commented Apr 11, 2019

I believe this was a trivial contribution as it was literally a copy/paste of the original code, and closely mimics previous code in the history, so this can pretty much be considered a code reversion.

As a side note to this process:

@mihaibuzgau
Copy link
Contributor

👍 Thanks, @coreone for the contribution

@mihaibuzgau mihaibuzgau merged commit fa447d9 into puppetlabs:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants