Linux Mint Support #434
Merged
Linux Mint Support #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
ciprianbadescu
suggested changes
Sep 30, 2019
ciprianbadescu
approved these changes
Sep 30, 2019
donoghuc
reviewed
Sep 30, 2019
| "Linuxmint"|"LinuxMint") | ||
| info "Mint platform! Lets get you a DEB..." | ||
| case $major_version in | ||
| "3") deb_codename="stretch";; |
There was a problem hiding this comment.
I do not have a way to test this, is "3" what the $major_version will resolve to? What version of the facts module are you using?
There was a problem hiding this comment.
3 is LMDE
18, 19 is LinuxMint
nicklewis
reviewed
Sep 30, 2019
donoghuc
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Even though we wont be adding automated tests for this platform, this seems like a very low risk addition. @luckyraul would you mind squashing the commits and adding a commit message that describes the change?
gimmyxd
pushed a commit
to gimmyxd/puppetlabs-puppet_agent
that referenced
this pull request
Jan 23, 2020
* Linux Mint Support * merge patterns * fix download_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.