(PE-10132) Remove old PE 3.8 repo

[ericwilliamson]

Previous to this commit, for PE users upgrading that had originally
installed via the simplified installer, the old repo definition was left
around pointing to a file path on the master that no longer exists due
to file path changes.

[ericwilliamson]

ping @MikaelSmith @jpartlow

before:

<SNIP>
Notice: /Stage[main]/Apt::Update/Exec[apt_update]/returns: 
Notice: /Stage[main]/Apt::Update/Exec[apt_update]/returns: E: Some index files failed to download. They have been ignored, or old ones used instead.
Error: /Stage[main]/Apt::Update/Exec[apt_update]: Failed to call refresh: /usr/bin/apt-get update returned 100 instead of one of [0]
Error: /Stage[main]/Apt::Update/Exec[apt_update]: /usr/bin/apt-get update returned 100 instead of one of [0]
Notice: forcing apt update for pc1_repo
Notice: /Stage[main]/Puppet_agent::Osfamily::Debian/Notify[pc1_repo_force]/message: defined 'message' as 'forcing apt update for pc1_repo'
Notice: /Stage[main]/Puppet_agent::Install/Package[puppet-agent]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Puppet_agent::Service/Service[puppet]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Puppet_agent::Service/Service[puppet]: Unscheduling refresh on Service[puppet]
Notice: /Stage[main]/Puppet_agent::Service/Service[mcollective]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Puppet_agent::Service/Service[mcollective]: Unscheduling refresh on Service[mcollective]
Notice: Finished catalog run in 16.35 seconds

after:

root@kn76zomum29tlos:~# puppet agent -t
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for kn76zomum29tlos.delivery.puppetlabs.net
Info: Applying configuration version '1436484062'
Notice: /Stage[main]/Puppet_agent::Prepare::Puppet_config/Ini_setting[agent/localconfig]/ensure: removed
Notice: /Stage[main]/Puppet_agent::Prepare::Puppet_config/Ini_setting[main/vardir]/ensure: removed
Notice: /Stage[main]/Puppet_agent::Prepare::Puppet_config/Ini_setting[main/rundir]/ensure: removed
Notice: /Stage[main]/Puppet_agent::Prepare::Mco_server_config/Ini_setting[server/libdir]/value: value changed '/opt/puppet/libexec/mcollective/' to '/opt/puppetlabs/mcollective/plugins:/opt/puppet/libexec/mcollective/'
Notice: /Stage[main]/Puppet_agent::Prepare::Mco_server_config/Ini_setting[server/plugin.yaml]/value: value changed '/etc/mcollective/facts.yaml' to '/etc/mcollective/facts.yaml:/etc/puppetlabs/mcollective/facts.yaml'
Notice: /Stage[main]/Puppet_agent::Prepare::Mco_server_config/Ini_setting[server/logfile]/value: value changed '/var/log/pe-mcollective' to '/var/log/puppetlabs/mcollective.log'
Notice: /Stage[main]/Apt/File[preferences]/ensure: created
Info: /Stage[main]/Apt/File[preferences]: Scheduling refresh of Exec[apt_update]
Notice: /Stage[main]/Apt/Apt::Setting[conf-update-stamp]/File[/etc/apt/apt.conf.d/15update-stamp]/content:
--- /etc/apt/apt.conf.d/15update-stamp  2012-05-15 16:22:32.000000000 -0700
+++ /tmp/puppet-file20150709-3261-1b1ej6c   2015-07-09 16:21:05.458620502 -0700
@@ -1 +1,2 @@
+# This file is managed by Puppet. DO NOT EDIT.
 APT::Update::Post-Invoke-Success {"touch /var/lib/apt/periodic/update-success-stamp 2>/dev/null || true";};

Info: Computing checksum on file /etc/apt/apt.conf.d/15update-stamp
Info: /Stage[main]/Apt/Apt::Setting[conf-update-stamp]/File[/etc/apt/apt.conf.d/15update-stamp]: Filebucketed /etc/apt/apt.conf.d/15update-stamp to main with sum b9de0ac9e2c9854b1bb213e362dc4e41
Notice: /Stage[main]/Apt/Apt::Setting[conf-update-stamp]/File[/etc/apt/apt.conf.d/15update-stamp]/content: content changed '{md5}b9de0ac9e2c9854b1bb213e362dc4e41' to '{md5}4355b3e7824866a503fc221621fc65ba'
Info: /Stage[main]/Apt/Apt::Setting[conf-update-stamp]/File[/etc/apt/apt.conf.d/15update-stamp]: Scheduling refresh of Exec[apt_update]
Notice: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Setting[conf-pc1_repo]/File[/etc/apt/apt.conf.d/90pc1_repo]/ensure: defined content as '{md5}4c7ee702ecee20258cf5ce7ea407a837'
Info: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Setting[conf-pc1_repo]/File[/etc/apt/apt.conf.d/90pc1_repo]: Scheduling refresh of Exec[apt_update]
Info: Computing checksum on file /etc/apt/sources.list.d/puppet-enterprise-installer.list
Info: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Setting[list-puppet-enterprise-installer]/File[/etc/apt/sources.list.d/puppet-enterprise-installer.list]: Filebucketed /etc/apt/sources.list.d/puppet-enterprise-installer.list to main with sum d2cc8af025a50811ccb8b9c8bee9555f
Notice: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Setting[list-puppet-enterprise-installer]/File[/etc/apt/sources.list.d/puppet-enterprise-installer.list]/ensure: removed
Info: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Setting[list-puppet-enterprise-installer]/File[/etc/apt/sources.list.d/puppet-enterprise-installer.list]: Scheduling refresh of Exec[apt_update]
Notice: /Stage[main]/Main/Apt::Setting[conf-pe-repo]/File[/etc/apt/apt.conf.d/90pe-repo]/ensure: removed
Notice: /Stage[main]/Apt::Update/Exec[apt_update]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Source[pc1_repo]/Apt::Setting[list-pc1_repo]/File[/etc/apt/sources.list.d/pc1_repo.list]/ensure: created
Info: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Source[pc1_repo]/Apt::Setting[list-pc1_repo]/File[/etc/apt/sources.list.d/pc1_repo.list]: Scheduling refresh of Exec[apt_update]
Notice: /Stage[main]/Apt::Update/Exec[apt_update]: Triggered 'refresh' from 5 events
Notice: forcing apt update for pc1_repo
Notice: /Stage[main]/Puppet_agent::Osfamily::Debian/Notify[pc1_repo_force]/message: defined 'message' as 'forcing apt update for pc1_repo'
Notice: /Stage[main]/Puppet_agent::Install/Package[puppet-agent]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Puppet_agent::Service/Service[puppet]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Puppet_agent::Service/Service[puppet]: Unscheduling refresh on Service[puppet]
Notice: /Stage[main]/Puppet_agent::Service/Service[mcollective]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Puppet_agent::Service/Service[mcollective]: Unscheduling refresh on Service[mcollective]
Notice: Finished catalog run in 17.19 seconds

[MikaelSmith]

👍

[MikaelSmith]

Worth extending specs to cover the new resources?

[MikaelSmith]

Lint fails

[ericwilliamson]

fixed