(MODULES-10666) Stop agent run after an upgrade #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielNagy
force-pushed
the
MODULES-10666/stop-run-after-upgrade
branch
from
bc58bf1 to
9d717fe
Compare
|
CLA signed by all contributors. |
joshcooper
reviewed
May 21, 2020
GabrielNagy
force-pushed
the
MODULES-10666/stop-run-after-upgrade
branch
6 times, most recently
from
4a78fd6 to
7d4d3d5
Compare
joshcooper
approved these changes
Jun 10, 2020
GabrielNagy
force-pushed
the
MODULES-10666/stop-run-after-upgrade
branch
from
7d4d3d5 to
6ed2d85
Compare
|
I added a note in the readme to reflect this change in functionality. This should be ready to merge now. |
gimmyxd
approved these changes
Jun 11, 2020
| false | ||
| end | ||
|
|
||
| def needs_upgrade |
There was a problem hiding this comment.
you could rename this to needs_upgrade? as it is the convention for methods that return a boolean
LE: also you could make this method private
GabrielNagy
force-pushed
the
MODULES-10666/stop-run-after-upgrade
branch
2 times, most recently
from
5214a6c to
92f4f73
Compare
|
All green!
|
GabrielNagy
force-pushed
the
MODULES-10666/stop-run-after-upgrade
branch
2 times, most recently
from
eb8b0e7 to
4883763
Compare
Previously, when evaluating additional resources after a puppet-agent upgrade, we could get to a point where we had a mixture of old/new Ruby code loaded in memory. This may cause unexpected behavior if the new code tries to execute something not available in the already loaded old code. This commit introduces a new type/provider that is evaluated whenever a puppet-agent upgrade happens on a platform managed with the package resource (AIX, Debian, EL, Suse). The newly added resource attempts to figure out if a Puppet upgrade was performed, then stops the run altogether. If Puppet is being run as a service, the HUP signal will have the daemon trigger a subsequent Puppet run that will evaluate the remaining resources. When running `puppet agent -t` manually, it is up to the user to rerun the command after the puppet-agent upgrade.
GabrielNagy
force-pushed
the
MODULES-10666/stop-run-after-upgrade
branch
from
4883763 to
d26fab5
Compare
GabrielNagy
added a commit
to GabrielNagy/puppetlabs-puppet_agent
that referenced
this pull request
Jun 15, 2020
We've chosen to do a major release due to the significant changes brought on by MODULES-10666. See: puppetlabs#496
GabrielNagy
added a commit
to GabrielNagy/puppetlabs-puppet_agent
that referenced
this pull request
Jun 15, 2020
We've chosen to do a major release due to the significant changes brought on by MODULES-10666. See: puppetlabs#496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when evaluating additional resources after a puppet-agent
upgrade, we could get to a point where we had a mixture of old/new
Ruby code loaded in memory. This may cause unexpected behavior if the
new code tries to execute something not available in the already
loaded old code.
This commit introduces a new type/provider that is evaluated whenever
a puppet-agent upgrade happens on a platform managed with the package
resource (AIX, Debian, EL, Suse).
The newly added resource attempts to figure out if a Puppet upgrade
was performed, then stops the run altogether. If Puppet is being run
as a service, the HUP signal will have the daemon trigger a subsequent
Puppet run that will evaluate the remaining resources.
When running
puppet agent -tmanually, it is up to the user to rerunthe command after the puppet-agent upgrade.