(MODULES-10897) Fix GPG key typo #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphoney
approved these changes
Jan 13, 2021
|
Thanks for the fix. @GabrielNagy great catch |
GabrielNagy
force-pushed
the
MODULES-10897/update-gpg-key-v2
branch
from
ab4d229 to
956a958
Compare
Accidentaly removed the RPM part of the filename when getting the GPG key for SLES in the install task. This commit adds it back and imports both keys when installing puppet_agent on SLES, for compatibility reasons.
GabrielNagy
force-pushed
the
MODULES-10897/update-gpg-key-v2
branch
from
956a958 to
277bf6a
Compare
|
@GabrielNagy why are you installing 2 keys ? puppet and puppet-20250406 |
|
@tphoney I think packages are not yet signed with the new key, and that's why SLES 15 failed when only importing the 2025 one. By having both imported we avoid these types of failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentaly removed the RPM part of the filename when getting the GPG
key for SLES in the install task. This commit adds it back.