(MODULES-10909) Commands retry on network connectivity failures #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianiurca
changed the title
adrianiurca
changed the title
adrianiurca
changed the title
|
The ticket specifically calls out Windows hiccups, but this doesn't seem to modify the PowerShell task as well? It seems like it'd be useful, for us and users, to add it there too. |
luchihoratiu
reviewed
Feb 3, 2021
|
Added a commit with some changes after discussing with @adrianiurca. Manually tested all the changes using Bolt on Microsoft Windows 2019, SLES 11, SLES 15 and Ubuntu 18.04 and seems to be working as expected. |
lucywyman
reviewed
Feb 4, 2021
lucywyman
approved these changes
Feb 4, 2021
GabrielNagy
reviewed
Feb 4, 2021
GabrielNagy
reviewed
Feb 4, 2021
Before this commit, the install tasks (`install_shell.sh` and `install_powershell.ps1`) exited at the first network connectivity failure. This change adds a retry mechanism to the `wget`, `curl`, `fetch`, `perl`, `yum`, `zypper`, `apt-get` (Linux) and `System.Net.Webclient.DownloadFile` (Windows) commands which waits one second between attempts. The number of attempts is `5` by default but can be configured via the new retry setting.
luchihoratiu
changed the title
|
Squashed the commits and updated the commit message/description. |
GabrielNagy
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the install tasks (
install_shell.shandinstall_powershell.ps1) exited at the first network connectivity failure. This change adds a retry mechanism to thewget,curl,fetch,perl,yum,zypper,apt-get(Linux) andSystem.Net.Webclient.DownloadFile(Windows) commands which waits one second between attempts. The number of attempts is5by default but can be configured via the newretrysetting.