Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9798) Add Timeout Parameter for the Current Puppet Run #537

Merged
merged 1 commit into from
Mar 23, 2021
Merged

(MODULES-9798) Add Timeout Parameter for the Current Puppet Run #537

merged 1 commit into from
Mar 23, 2021

Conversation

phil4business
Copy link
Contributor

  • (Support-42796) Add wait_for_puppet_run parameter to configure the timeout value for the current puppet run.
    Previously, if the puppet agent was to be upgraded but the current run took longer than 120000 ms (2 minutes) to complete, the agent upgrade script (install_puppet.ps1) would fail. This would happen even if the agent run would have otherwise completed without error.

  • Fixed wait_for_pxp_agent_exit parameter tests. The parameter accepts an Int32, but the tests were passing booleans.

@phil4business phil4business requested a review from a team February 3, 2021 17:06
@puppet-community-rangefinder
Copy link

puppet_agent is a class

that may have no external impact to Forge modules.

puppet_agent::install::windows is a class

that may have no external impact to Forge modules.

This module is declared in 3 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @phil4business, thanks for your contribution! 🎉

The PR looks good, good catch on the spec tests. Also, we really appreciate the effort to keep the documentation up-to-date.

I found a JIRA ticket that relates to this: https://tickets.puppetlabs.com/browse/MODULES-9798

To get PR checks to pass, can you squash your commits and prepend the ticket ID to your commit? Something like (MODULES-9798) Add Timeout Parameter for the Current Puppet Run. Let me know if you need any help with this.

Add `wait_for_puppet_run` parameter to configure the timeout value for
the current puppet run.

Previously, if the puppet agent was to be upgraded but the current run
took longer than 120000 ms (2 minutes) to complete, the agent upgrade
script (install_puppet.ps1) would fail. This would happen even if the
agent run would have otherwise completed without error.

Fix wait_for_pxp_agent_exit tests. Parameter accepts Int32, the tests
were passing a boolean value.
@GabrielNagy GabrielNagy changed the title Add Timeout Parameter for the Current Puppet Run (MODULES-9798) Add Timeout Parameter for the Current Puppet Run Mar 23, 2021
@GabrielNagy GabrielNagy merged commit d6f634e into puppetlabs:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants