Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint). Add fact-limit configuration options to list. #584

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

Heidistein
Copy link
Contributor

There are two fairly new options which go in puppet.conf.

There are two fairly new options which go in puppet.conf.
@Heidistein Heidistein requested a review from a team October 11, 2021 07:59
@GabrielNagy
Copy link
Contributor

Hey @Heidistein, thanks for the contribution!

These are all the puppet settings with soft_limit, we should probably add them all:

lib/puppet/defaults.rb
1698:    :fact_name_length_soft_limit => {
1703:    :fact_value_length_soft_limit => {
1708:    :top_level_facts_soft_limit => {
1713:    :number_of_facts_soft_limit => {
1718:    :payload_soft_limit => {

Also, the Static Code Analysis should pass if you prefix your commit message with (maint).

@Heidistein Heidistein changed the title Add fact-limit configuration options to list. (maint). Add fact-limit configuration options to list. Oct 11, 2021
@Heidistein
Copy link
Contributor Author

I added the other options as well. Perhaps I did it correctly.

Copy link
Contributor

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@GabrielNagy GabrielNagy merged commit e24a8c1 into puppetlabs:main Oct 12, 2021
@cthorn42 cthorn42 added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants